Patch 1 and 2 look fine to me. While it look a bit like a change in semantics, given the possibility of race conditions etc, clients could never make any assumptions about any state in future configure events.
The third patch, however, is more problematic, as it is possible that clients may have made the assumption that at least it'll get a new configure event if it made a request. I think the gain of not sending a event in this case doesn't give us anything worth while, as sending events that can be ignored is very cheap. So, patch 1 and 2 are Reviewed-by: Jonas Ådahl <[email protected]> but patch 3, so far is not. Jonas On Fri, Jul 20, 2018 at 11:09:31AM +0200, [email protected] wrote: > From: Markus Ongyerth <[email protected]> > > v2 was > https://lists.freedesktop.org/archives/wayland-devel/2018-June/038734.html > > Changes from v2: > Moved the word wrapping change into the first commit, as pointed out by Simon. > > Markus Ongyerth (3): > xdg-shell: move maximized state definition together > xdg-shell: Make sure wording reflects expectations > xdg-shell: Give compositor control over configure > > stable/xdg-shell/xdg-shell.xml | 78 ++++++++++++++++++++-------------- > 1 file changed, 45 insertions(+), 33 deletions(-) > > -- > 2.18.0 > > _______________________________________________ > wayland-devel mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/wayland-devel _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
