On 25 July 2018 at 18:36, Derek Foreman <[email protected]> wrote:
> On 2018-07-21 06:13 AM, Daniel Stone wrote:
>> The check for the execinfo.h header is only advisory; the build will not
>> fail if it is not present, and set HAVE_EXECINFO_H if it is. The check
>> was added in commit 5cfdbef3d299 ("build: Allow disabling building of
>> wayland libraries") with no obvious use or reasoning.
>
> 5cfdbe3d299 just moved it, it was added in commit bc3e020475
>
> It appears to have been accidentally included there, as it doesn't look
> relevant to the bug ticket referenced in the commit.
>
>> Remove the no-op check.
>>
>> Signed-off-by: Daniel Stone <[email protected]>
>
> Reviewed-by: Derek Foreman <[email protected]>
>
> Though, I wouldn't mind seeing a more accurate commit log. ;)
>
It's always better to not get called out for other's copy/paste
mistakes. If you guys like Fixes tags, here is one
Fixes: bc3e020475e ("build: Add declaration checks to check for
required syscall flags")
Fwiw, series is
Reviewed-by: Emil Velikov <[email protected]>
-Emil
_______________________________________________
wayland-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/wayland-devel
