On Mon, 9 Jul 2018 12:39:30 +0300 Pekka Paalanen <[email protected]> wrote:
> On Thu, 5 Jul 2018 18:16:40 +0100 > Daniel Stone <[email protected]> wrote: > > > Add support for the GBM_BO_IMPORT_FD_MODIFIER path, which allows us to > > import multi-plane dmabufs, as well as format modifiers. > > > > Signed-off-by: Daniel Stone <[email protected]> > > Tested-by: Emre Ucan <[email protected]> > > --- > > configure.ac | 6 +- > > libweston/compositor-drm.c | 181 +++++++++++++++++++++++++++---------- > > 2 files changed, 137 insertions(+), 50 deletions(-) > > + > > +static struct drm_fb * > > +drm_fb_get_from_dmabuf(struct linux_dmabuf_buffer *dmabuf, > > + struct drm_backend *backend, bool is_opaque) > > +{ Hi, one more complication: Because is_opaque state is now baked in to drm_fb, if drm_fb_get_from_bo() returns an existing drm_fb for a bo, we need to make sure is_opaque still matches. I think is_opaque might change if the application is recycling dmabuf wl_buffers without destroying them (as intended), but changes the wl_surface opaque region according to its rendering. Thanks, pq
pgpnmFuL6LiNC.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
