On Wed, 06 Jun 2018 at 15:33:13 +0100, Emil Velikov wrote: > On 5 June 2018 at 23:06, Daniel Stone <[email protected]> wrote: > > + - apt-get -y --no-install-recommends install build-essential automake > > autoconf libtool pkg-config libexpat1-dev libffi-dev libxml2-dev > > libpixman-1-dev libpng-dev libjpeg-dev libcolord-dev mesa-common-dev > > libglu1-mesa-dev libegl1-mesa-dev libgles2-mesa-dev libwayland-dev > > libxcb1-dev libxcb-composite0-dev libxcb-xfixes0-dev libxcb-xkb-dev > > libx11-xcb-dev libx11-dev libudev-dev libgbm-dev libxkbcommon-dev > > libcairo2-dev libpango1.0-dev libgdk-pixbuf2.0-dev libxcursor-dev > > libmtdev-dev libpam0g-dev libvpx-dev libsystemd-dev libinput-dev > > libwebp-dev libjpeg-dev libva-dev liblcms2-dev git > > I think this can be simplify the explicit list to: > apt-get -y --no-install-recommends build-dep wayland
Only if the latest version of wayland has the same build-dependencies as the (likely much older) version visible in the Sources index for the container's apt configuration. If the container is Debian 9 'stretch' (released about a year ago) then apt-get build-dep will get the build-dependencies of wayland 1.12.0, according to <https://tracker.debian.org/pkg/wayland>. > > + - make -j4 > > + - make check > > + - make install > > + - make distcheck > I was under the impression that "make -j4 distcheck" is enough install and check both imply (depend on) a normal build, so that one is redundant. distcheck runs the tests like check does, but differently-configured, so for full coverage you might want to do both. Similarly, distcheck runs "make install", but into a temporary directory, not the requested $PREFIX. > Alternatively it's worth setting MAKEFLAGS="-jX" once so it's used across all. Using -j would definitely help for "make distcheck". If parallel install works, it would be good to test it so that it stays that way: quite a lot of projects can build correctly in parallel, but don't work reliably for "make -jX install". smcv _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
