Hi Emre I ask why calling it? which scenario could reproduce the issue you said "keep visible after set layer/surface invisible "?
Thank you. Best Regards Nancy 2018-04-10 22:19 GMT+08:00 Ucan, Emre (ADITG/ESB) <[email protected]>: > Hi, > > > > Are you asking if it is possible to move weston_view_damage_below() to > commit_screen_list ? or are you asking why we are calling it ? > > > > Best regards > > *Emre Ucan* > Engineering Software Base (ADITG/ESB) > > Tel. +49 5121 49 6937 > > *From:* zou lan [mailto:[email protected]] > *Sent:* Dienstag, 10. April 2018 08:55 > *To:* Pekka Paalanen > *Cc:* Ucan, Emre (ADITG/ESB); [email protected] > *Subject:* Re: [PATCH weston v2] ivi-shell: Damage view below after > unmapping > > > > Hi Emre > > > > I have a question about this change: > > > > Is the commit_screen_list function not enough to handle the > layer/surface's visibility? Why need to handle visibility in > commit_changes? They are called ivi_layout_commit_changes together. > > > > Best Regards > > Nancy > > > > 2017-02-07 21:04 GMT+08:00 Pekka Paalanen <[email protected]>: > > On Tue, 7 Feb 2017 12:55:59 +0000 > "Ucan, Emre (ADITG/SW1)" <[email protected]> wrote: > > > If ivilayer or ivisurf of ivi_view is made invisible in the > > commit_changes call, we have to damage the weston_view below this > > ivi_view. Otherwise content of this ivi_view will stay visible. > > > > Signed-off-by: Emre Ucan <[email protected]> > > --- > > ivi-shell/ivi-layout.c | 13 ++++++++++++- > > 1 file changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c > > index 712cc30..64e4ead 100644 > > --- a/ivi-shell/ivi-layout.c > > +++ b/ivi-shell/ivi-layout.c > > @@ -681,8 +681,19 @@ commit_changes(struct ivi_layout *layout) > > * If the view's layer or surface is invisible, we do not > need > > * to update its properties. > > */ > > - if (!ivilayer->prop.visibility || > !ivisurf->prop.visibility) > > + if (!ivilayer->prop.visibility || > !ivisurf->prop.visibility) { > > + /* > > + * If ivilayer or ivisurf of ivi_view is made > invisible > > + * in this commit_changes call, we have to damage > > + * the weston_view below this ivi_view. Otherwise > content > > + * of this ivi_view will stay visible. > > + */ > > + if ((ivilayer->prop.event_mask | > ivisurf->prop.event_mask) && > > + IVI_NOTIFICATION_VISIBILITY) > > + weston_view_damage_below(ivi_view->view); > > + > > continue; > > + } > > > > update_prop(ivi_view); > > } > > Hi, > > looks fine to me, pushed: > 19222b4..7fe0bb2 master -> master > > > Thanks, > pq > > _______________________________________________ > wayland-devel mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/wayland-devel > > >
_______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
