On Fri, 9 Mar 2018 11:32:47 -0600 Derek Foreman <[email protected]> wrote:
> On 2018-03-09 05:44 AM, Pekka Paalanen wrote: > > From: Pekka Paalanen <[email protected]> > > > > There are multiple copies for the timerfd handling code, and I need a > > timer in one more app. Consolidate all the timerfd code into window.c to > > reduce the duplication. Many of the copies were also flawed against the > > race mentioned in toytimer_fire(). > > > > This patch handles clickdot and window.c's tooltip timer and cursor > > timer. > > > > Signed-off-by: Pekka Paalanen <[email protected]> > > Just out of curiosity, how'd you decide to break it down this way? Mind flow. First I thought of doing just one patch, but it started to look a bit big, the window.c parts particularly. No rationale behind the split, for once. :-) > Both patches look good to me. I hate that reset/fire race and wasted a > bit of time understanding it the first time I hit it. I'm really happy > to see it handled consistently in one place. > > Reviewed-by: Derek Foreman <[email protected]> > For both. Thank you. > I think they look safe to land now, as it's mostly harmless refactor, > and the rest is actual bug fix, as abort()ing on the read fail was wrong. > > I'll let you make the call on landing it. :) Thank you to Daniel as well for the comments, pushed: 3f839374..64a26bc1 master -> master Thanks, pq
pgpIW2C8bneEb.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
