[PATCH v15 08/34] compositor-drm: Add blob_id member to drm_mode

[Daniel Stone]

For atomic modesetting support, the mode is identified by a blob
property ID, rather than being passed inline. Add a blob_id member to
drm_mode to handle this, including refactoring mode destruction into a
helper function.

Signed-off-by: Daniel Stone <dani...@collabora.com>
Reviewed-by: Pekka Paalanen <pekka.paala...@collabora.co.uk>
---
 libweston/compositor-drm.c | 20 ++++++++++++++++----
 1 file changed, 16 insertions(+), 4 deletions(-)

diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c
index ee5499497..b1e812141 100644
--- a/libweston/compositor-drm.c
+++ b/libweston/compositor-drm.c
@@ -234,6 +234,7 @@ struct drm_backend {
 struct drm_mode {
        struct weston_mode base;
        drmModeModeInfo mode_info;
+       uint32_t blob_id;
 };
 
 enum drm_fb_type {
@@ -3369,6 +3370,7 @@ drm_output_add_mode(struct drm_output *output, const 
drmModeModeInfo *info)
 
        mode->base.refresh = refresh;
        mode->mode_info = *info;
+       mode->blob_id = 0;
 
        if (info->type & DRM_MODE_TYPE_PREFERRED)
                mode->base.flags |= WL_OUTPUT_MODE_PREFERRED;
@@ -3378,6 +3380,18 @@ drm_output_add_mode(struct drm_output *output, const 
drmModeModeInfo *info)
        return mode;
 }
 
+/**
+ * Destroys a mode, and removes it from the list.
+ */
+static void
+drm_output_destroy_mode(struct drm_backend *backend, struct drm_mode *mode)
+{
+       if (mode->blob_id)
+               drmModeDestroyPropertyBlob(backend->drm.fd, mode->blob_id);
+       wl_list_remove(&mode->base.link);
+       free(mode);
+}
+
 static int
 drm_subpixel_to_wayland(int drm_value)
 {
@@ -4336,10 +4350,8 @@ drm_output_destroy(struct weston_output *base)
        }
 
        wl_list_for_each_safe(drm_mode, next, &output->base.mode_list,
-                             base.link) {
-               wl_list_remove(&drm_mode->base.link);
-               free(drm_mode);
-       }
+                             base.link)
+               drm_output_destroy_mode(b, drm_mode);
 
        if (output->pageflip_timer)
                wl_event_source_remove(output->pageflip_timer);
-- 
2.14.3

_______________________________________________
wayland-devel mailing list
wayland-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/wayland-devel