Hi, On 18 July 2017 at 14:31, Pekka Paalanen <[email protected]> wrote: > On Fri, 7 Jul 2017 10:51:16 +0200 Olivier Blin <[email protected]> > wrote: >> Also note that this requires a relatively new pkg-config for PKG_CHECK_VAR. >> The macro appeared in pkg-config 0.28, from January 2013. >> >> It is for example not available in Ubuntu 14.04 LTS, which only provides >> pkg-config 0.26. > > Hi, > > is anyone actually against requiring pkg-config 0.28? It sounds fine to > me, so I'll give: > Acked-by: Pekka Paalanen <[email protected]>
I think requiring it is fine. > I think the pkg-config's own version check would need bumping, and I > have a feeling the above M4 could use more quoting just in case. Yes, the second and third arguments should be quoted. > If the MODULE requirement for PKG_CHECK_VAR is not satisfied, does it > fail the whole configure like we would want? The documentation does not > say. It doesn't, but takes action-if-found and action-if-not-found arguments. Olivier, could you please respin to add an AC_MSG_ERROR failure when it's not found? Cheers, Daniel _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
