Hi, Meant 'patch' rather than 'series' when offering my R-b to the other patch. Oops.
On 11 October 2017 at 10:00, Jonas Ådahl <[email protected]> wrote: > + # Check that header can be included by a pedantic C99 compiler > + test_name = 'test-build-pedantic-@0@'.format(protocol.underscorify()) > + test_name_source = '@[email protected]'.format(test_name) > + test_source = custom_target(test_name_source, > + input: 'build-pedantic.c.in', > + output: test_name_source, > + command: replace_command) > + pedantic_test_executable = executable(test_name, > + [ test_source, > + client_header, > + server_header, > + code ], > + dependencies: libwayland, > + c_args: [ '-std=c99', > + '-pedantic', > + '-Wall', > + '-Werror' ], > + install: false) > + test(test_name, pedantic_test_executable) > + > + # Check that the header > + if not protocol.contains('xdg-foreign-unstable-v1') The comment ends abruptly, the xdg_foreign exclusion is a massive non-sequitur, and also test_configuration can be deleted. With that, this is also: Reviewed-by: Daniel Stone <[email protected]> Cheers, Daniel _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
