On 18/09/2017, 12.58, "Pekka Paalanen" <[email protected]> wrote: > > On Fri, 15 Sep 2017 09:12:38 +0300 > Ian Ray <[email protected]> wrote: > > > Support for kiosk-style use cases where binding modififer is `none': > > > > - Use binding modifier instead of hard-coded MODIFIER_SUPER for zoom. > > - Disable opacity zoom if there is no binding modifier. > > > > Hello Ian, > > strictly speaking, as you can see from the bullet list this patch does > two things so it should really be two patches. The summary line doesn't > really mention both things either. > > This patch disables both zoom and opacity bindings when the modifier is > configured to 'none' in weston.ini. This is for kiosk use cases where > one does not want to have these bindings. > > This patch changes the zoom binding to use the configured modifier > instead of hardcoding MODIFIER_SUPER. I suppose you don't actually need > this part. > > Personally I'm fine with both changes, but I would like to see them in > separate patches where the summary lines clearly point out the user > visible changes and commit messages justify them.
Thank you for the review, pq, I will submit a V2. > Thanks, > pq > > > Signed-off-by: Ian Ray <[email protected]> > > --- > > desktop-shell/shell.c | 16 ++++++++++------ > > 1 file changed, 10 insertions(+), 6 deletions(-) <snip> _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
