On Thu, 27 Jul 2017 11:54:43 +0100
Daniel Stone <[email protected]> wrote:

> Hi,
> 
> On 27 July 2017 at 11:51, Pekka Paalanen <[email protected]> wrote:
> > @@ -2810,6 +2820,7 @@ create_output_for_connector(struct drm_backend *b,
> >         if (output == NULL)
> >                 goto err;
> >
> > +       output->state_invalid = true;
> >         output->connector = connector;
> >         output->crtc_id = resources->crtcs[i];
> >         output->pipe = i;
> > @@ -3130,6 +3141,10 @@ session_notify(struct wl_listener *listener, void 
> > *data)
> >                 weston_log("activating session\n");
> >                 weston_compositor_wake(compositor);
> >                 weston_compositor_damage_all(compositor);
> > +
> > +               wl_list_for_each(output, &compositor->output_list, 
> > base.link)
> > +                       output->state_invalid = true;
> > +  
> 
> In addition to output creation, and on VT enter, should we also be
> resetting the state on output enable? Or maybe just moving it there
> from create_output_for_connector, rather than both. Either way:

Hi,

yes, we should indeed. But I don't think enable is called on VT enter,
so we still need it on VT enter explicitly. I'll remove it from create
output, as that path always goes through enable, and have it in enable.

> Reviewed-by: Daniel Stone <[email protected]>

Will test and push.


Thanks,
pq

Attachment: pgpejk6NWJ4Hk.pgp
Description: OpenPGP digital signature

_______________________________________________
wayland-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/wayland-devel

Reply via email to