Le lundi 24 avril 2017 à 16:22 +1000, Peter Hutterer a écrit : > On Fri, Apr 21, 2017 at 01:31:58PM +0200, Paul Kocialkowski wrote: > > The high pressure value for Elantech touchpads (both PS/2 and I2C) is > > not adapted to various devices, on which the touchpad is barely usable. > > > > Decreasing the high value makes those devices usable again, while not > > introducing any major drawback for other devices. > > that's not quite true, is it? Bug 99975 which is the source for the 24/10 > (yes, I had a copy/paste in the pressure patch, this should be 24:10, not > 24:8, I've fixed this locally) had the user specifically set this. Anything > lower is likely to introduce ghost touches again. I'm ok to reduce this to > 10:8 generically (synaptics used 1:1) but this should be added with a > hw-specific setting for that machine in bug 99975.
That's a good point! However, I think we should make 10:8 the default and 24:10 specific to this case, because ghost touch seems less problematic than not being able to use the touchpad at all. If that's okay, I'll ask for a dmi id string to use on the bug report and do things this way. Thanks for the review, Paul > > Signed-off-by: Paul Kocialkowski <[email protected]> > > --- > > udev/90-libinput-model-quirks.hwdb | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/udev/90-libinput-model-quirks.hwdb b/udev/90-libinput-model- > > quirks.hwdb > > index a78b5a9..0487165 100644 > > --- a/udev/90-libinput-model-quirks.hwdb > > +++ b/udev/90-libinput-model-quirks.hwdb > > @@ -88,12 +88,12 @@ libinput:name:* Touchpad:dmi:*svnDellInc.:* > > ########################################## > > libinput:name:*ETPS/2 Elantech Touchpad*:dmi:* > > LIBINPUT_ATTR_RESOLUTION_HINT=31x31 > > - LIBINPUT_ATTR_PRESSURE_RANGE=24:8 > > + LIBINPUT_ATTR_PRESSURE_RANGE=10:8 > > LIBINPUT_MODEL_ELANTECH_TOUCHPAD=1 > > libinput:name:*Elan Touchpad* > > LIBINPUT_MODEL_ELANTECH_TOUCHPAD=1 > > - LIBINPUT_ATTR_PRESSURE_RANGE=24:8 > > + LIBINPUT_ATTR_PRESSURE_RANGE=10:8 > > > related: looks like we can drop the ELANTECH_TOUCHPAD flag, it's write-only > now that we have the atttribute. > > Cheers, > Peter > > > > ########################################## > > # Google > > -- > > 2.12.2 > >
signature.asc
Description: This is a digitally signed message part
_______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
