On 14 March 2017 at 18:37, Yong Bakos <[email protected]> wrote: > Hi Emil, > >> On Feb 21, 2017, at 8:14 AM, Emil Velikov <[email protected]> wrote: >> >> From: Emil Velikov <[email protected]> >> >> With next commit we'll make wayland-util a shared library (for reasons >> mentioned in the commit). As such we need to make sure that the private >> symbols are somewhere that they can be used internally. Otherwise we'll >> end up with link errors. >> >> v2: Rebase. >> >> Signed-off-by: Emil Velikov <[email protected]> > > While others will certainly have to chime in and approve > patches 2 - 4, the remainder of this series is > > Reviewed-by: Yong Bakos <[email protected]> > Tested-by: Yong Bakos <[email protected]> > Thanks Yong.
If people are OK with the idea, I'll re-spin 2-4 with r-b/other tags and Eric's comment addressed... >> --- a/src/wayland-util.c >> +++ b/src/wayland-util.c >> @@ -30,8 +30,8 @@ >> #include <string.h> >> #include <stdarg.h> >> >> -#include "wayland-util.h" >> #include "wayland-private.h" >> +#include "wayland-util.h" >> ... namely: this move is not needed. Silly git rebase on my end. -Emil _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
