On Fri, 9 Dec 2016 19:57:33 +0000 Daniel Stone <dani...@collabora.com> wrote:
> We only need it for the GBM surface the FB was originally created > against; a mismatch here is very bad indeed, so no reason to pass it in > explictly every time rather than store it. > > Differential Revision: https://phabricator.freedesktop.org/D1490 > > Signed-off-by: Daniel Stone <dani...@collabora.com> > --- > libweston/compositor-drm.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/libweston/compositor-drm.c b/libweston/compositor-drm.c > index 7dbfc6b..eb735b2 100644 > --- a/libweston/compositor-drm.c > +++ b/libweston/compositor-drm.c > @@ -148,6 +148,7 @@ struct drm_fb { > > /* Used by gbm fbs */ > struct gbm_bo *bo; > + struct gbm_surface *gbm_surface; > > /* Used by dumb fbs */ > void *map; > @@ -466,7 +467,7 @@ drm_fb_set_buffer(struct drm_fb *fb, struct weston_buffer > *buffer) > } > > static void > -drm_output_release_fb(struct drm_output *output, struct drm_fb *fb) > +drm_fb_unref(struct drm_fb *fb) Hi, first I was slightly surprised by the renaming, but reading the patch thoroughly and seeing the following patch explained why it's nice to do here. It would have saved a bit of effort if it was mentioned in the commit message. Reviewed-by: Pekka Paalanen <pekka.paala...@collabora.co.uk> Thanks, pq
pgp4sQpVTTgju.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
