Hi Quentin, On 18 December 2016 at 13:26, Quentin Glidic <[email protected]> wrote: > Here is the second take at my common modules series, or rather at the > preparation > work. > > The real feature will come in a second series, with README update, and a > complete > design explanation. > > This series is merely a split and reordering of the first two patches frome > the > old series, with two modifications, as asked by reviewers: > - dropped the old "module_init" entirely > - maitained "modules=xwayland.so" compatibility
This all looks good to me, with a couple of minor quibbles. Firstly, the 'compositor/weston.h' changes don't seem like they belong in 2/5: why are we touching compositor modules in a libweston patch? Secondly, it would be nice if we could do wet_shell_init in one stage, rather than module_init -> wet_module_init -> wet_shell_init, but just typing that out makes me realise it may be more effort than it's worth. Either way, with 2/5 properly split (or convince me why it's necessary to combine them), let's get this merged early: Reviewed-by: Daniel Stone <[email protected]> Cheers, Daniel _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
