Hi, On 9 December 2016 at 20:37, Armin Krezović <krezovic.ar...@gmail.com> wrote: > On 09.12.2016 20:57, Daniel Stone wrote: >> libweston/pixel-formats.c | 398 >> ++++++++++++++++++++++++++++++++++++++++++++++ >> libweston/pixel-formats.h | 112 +++++++++++++ > > Where are corresponding build system modifications?
Missing, apparently ... :\ >> +#include <EGL/egl.h> >> +#include <EGL/eglext.h> >> +#include <GLES2/gl2.h> >> +#include <GLES2/gl2ext.h> > > Is it supposed to work without EGL/GLESv2 enabled? Not really, no; note that the DRM backend has a hard dependency on GBM and the Wayland backend has a hard dependency on libwayland-egl, so this only really affects people building the X11/headless backends only with no EGL. I suppose we could do a giant #ifdef tree, or just pull all the tokens we use into weston-egl-ext.h and use that. Do you have any preferences? >> +/** >> + * Table of DRM formats supported by Weston; RGB, ARGB and YUV formats are >> + * supported. Indexed/greyscale formats, and formats not containing complete >> + * colour channels, are not supported. >> + */ > > I expected something using this immediately. I suggest you squash it with > something > else that uses this. It could be squashed with 'Store format in drm_fb', but as the DRM-specific parts of the series were getting very little review, and it can also be useful for gl-renderer's SHM uploads in particular, I didn't want to muddle it in with the rest of the series. Depending on how that goes (whether I get to porting gl-renderer, if earlier parts of the series get reviewed so we can merge this, etc), it can be squashed into its first user. Cheers, Daniel
signature.asc
Description: PGP signature
_______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/wayland-devel
