On Mon, Nov 21, 2016 at 12:55:14PM +0000, Daniel Stone wrote: > Hi Bryce, > > On 20 November 2016 at 22:00, Bryce Harrington <[email protected]> wrote: > > Add support for basic text file loading, to facilitate more expansive > > testing of its UTF-8 text editing support. > > Honestly, I question the value of turning the editor into something > 'real': as soon as we're adding a --version argument to something,
Fair enough I can drop the --version, didn't expect that would be controversial. I have local and system installations of weston, so having tools report which weston they came from seemed useful, but not a big deal, there's plenty of other ways to determine that. I do think that an editor actually loading a file to edit is extraordinarily basic functionality; little risk there of making weston-editor 'real'. This small feature would have been moderately handy while working on the compose editing support, although I was more focused on input than display. I figure future developers working on text support might find use of being able to load up a file with test UTF-8 text. Remaining review comments incorporated, thanks. Bryce _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
