Hi Varad, > On Nov 17, 2016, at 11:32 PM, Varad Gautam <[email protected]> wrote: > > From: Varad Gautam <[email protected]> > > clearly state the request name in format event to avoid abmiguous > interpretation between 'zwp_linux_buffer_params_v1::create' and > 'zwp_linux_dmabuf_v1::create_params' requests. > > Suggested-by: Yong Bakos <[email protected]> > Signed-off-by: Varad Gautam <[email protected]>
One minor nit below but this is: Reviewed-by: Yong Bakos <[email protected]> > --- > unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml > b/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml > index 3b008ee..c6aa2cd 100644 > --- a/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml > +++ b/unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml > @@ -105,7 +105,8 @@ > binds to this interface. A roundtrip after binding guarantees > that the client has received all supported formats. > > - For the definition of the format codes, see create request. > + For the definition of the format codes, see > + zwp_linux_buffer_params_v1::create request. For the definition of the format codes, see the zwp_linux_buffer_params_v1::create request. (Note the 'the'.) yong > > XXX: Can a compositor ever enumerate them? > </description> > -- > 2.6.2 > > _______________________________________________ > wayland-devel mailing list > [email protected] > https://lists.freedesktop.org/mailman/listinfo/wayland-devel _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
