Hi Pekka, On 16 November 2016 at 11:46, Pekka Paalanen <[email protected]> wrote: > Put also test programs into noinst_PROGRAMS so that they get always > built. In check_PROGRAMS they are built for 'make check' but not for > 'make'. > > This makes it harder to accidentally break the test programs. > > Signed-off-by: Pekka Paalanen <[email protected]> > --- > Makefile.am | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index be372da..457f451 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -178,11 +178,9 @@ AM_TESTS_ENVIRONMENT = > \ > TESTS = $(built_test_programs) \ > tests/scanner-test.sh > > -check_PROGRAMS = \ > - $(built_test_programs) \ > - exec-fd-leak-checker > - > noinst_PROGRAMS = \ > + $(built_test_programs) \ > + exec-fd-leak-checker \ > fixed-benchmark > > check_LTLIBRARIES = libtest-runner.la
Doesn't this have to be (or at least, shouldn't: I can imagine autotools making it a non-issue, but it is at least unclean) noinst_LTLIBRARIES instead? With that: Reviewed-by: Daniel Stone <[email protected]> Cheers, Daniel _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
