On 5 July 2016 at 13:16, Quentin Glidic <[email protected]> wrote: > On 04/07/2016 15:57, Emil Velikov wrote: >> >> From: Emil Velikov <[email protected]> >> >> Otherwise we'll pick up the stale (in-tree) generated source(s) over the >> fresh (out-of-tree) ones. >> >> Signed-off-by: Emil Velikov <[email protected]> >> --- >> It's quite a corner case, although it could save you a lot of time >> debugging. >> --- > > > If the source directory is in a configured state, the configure script will > refuse to configure an out-of-tree build. That means these files are > leftovers from either a previous build or the dist tarball, I guess. > In both cases, they should be added to CLEANFILES or DISTCLEANFILES. > > In the meantime, this fix is not bad: > Reviewed-by: Quentin Glidic <[email protected]> >
The issue is present when working with git as well: - Attempt/do an in-tree build or otherwise generate the files. - Forget that the files are around and attempt and out-of tree build. - Boom. Whether to add them to CLEANFILES or DISTCLEANFILES depends on the policy adopted by the project. I've seen some which prefer to _keep_ all the generated files on make clean. Others do that only for release tarballs, while others... > In the meantime, this fix is not bad: > Reviewed-by: Quentin Glidic <[email protected]> > Hope that's the British definition of "not bad" :-) Thanks Emil _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
