On Thu, 23 Jun 2016 18:12:27 +1000 Daniel Stone <[email protected]> wrote:
> Hi, > > On 17 June 2016 at 00:13, Pekka Paalanen <[email protected]> wrote: > > Change create_shm_buffer() to handle any pixel format known to Pixman. > > Presumably in the future we might want to test e.g. RGB565 content with > > screenshot tests. > > Similarly to #1, this: > - uses the new struct buffer That happened in patch 1. > - moves from raw allocations to pixman_image_t That also happened in patch 1. > - adds support for other formats I suppose it's confused with the huge internal refactoring happening at the same time. At this point of the series, the only caller of static create_shm_buffer() is create_shm_buffer_a8r8g8b8(). Both are rewritten to work better together. I'm not sure how I'd untangle any of those from this patch. FWIW, this patch is not even necessary for the series, but this is a pre-requisite for a patch adding any new buffer formats for use. The alternative would have been to completely inline create_shm_buffer() into create_shm_buffer_a8r8g8b8(). > > Egads. :( Looks correct though. Thanks, pq
pgpYtpXShguNq.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
