Hi, On 17 June 2016 at 00:13, Pekka Paalanen <[email protected]> wrote: > I believe Pixman is the most future-proof approach, so I went with that, and > started doing everything in pixman_image_t's. > > The patch series works in simple steps: first introduce a struct buffer, which > contains a pixman_image_t and a wl_buffer. Then a new buffer allocator > explicitly for a8r8g8b8 format is introduced, and each test is converted to it > in turn. The old allocator function is hidden once there are no more outside > callers to it, and refactored to remove the pixel format and stride > assumptions. Next, the image comparing, loading and saving APIs are converted > to Pixman images. Cairo remains used for PNG files. Screenshooting returns a > buffer rather than a surface. Finally as a completely new feature, a function > to visualize image differences is added. > > An example of the image error visualisation is here: > https://people.collabora.com/~pq/internal-screenshot-error-00.png > The image represents the difference between a reference image and a > screenshot. The red is wrong, the green is right, and the dark is ignored. > > This series is a pre-requisite for a bunch of sub-surface screenshooting tests > I am developing.
LGTM, and wow do we ever need it. Reviewed-by: Daniel Stone <[email protected]> Cheers, Daniel _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
