Hi, On 19 May 2016 at 05:32, Benoit Gschwind <[email protected]> wrote: > In current compositor-x11, the mouse buttons are grabbed and ungrabbed > manually that may produce weird cases like starting a grab while the > buttons are already released, due to asynchronous X11 events dispatching. > > The patch avoid the issue by using the better passive button grab, that > automatically grab buttons as soon as they occur. The passive grab > include an automatic ungrab when all mouse button are released. > > This probably fix some mysterious bugs.
Hm, have you observed this in practice? Passing button_event->time, rather than CurrentTime, should ensure that the grab does not take effect if there has been another button press, since I believe that will subsequently update the last grab time in the server. Even if it did, we would ungrab the pointer as soon as we receive the button release - which we are guaranteed to do thanks to implicit grabs. I think it's a reasonable and good change to have, but am not convinced by the reasoning for it. Cheers, Daniel _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
