On Sun, 5 Jun 2016 23:37:57 +0100 Emil Velikov <[email protected]> wrote:
> Hi Yong, > > On 4 June 2016 at 01:58, Yong Bakos <[email protected]> wrote: > > Hi Emil, > > > > On Jun 3, 2016, at 8:27 AM, Emil Velikov <[email protected]> wrote: > >> > >> From: Emil Velikov <[email protected]> > >> > >> v2: Rewrap, add a couple of missing words (Pekka). > >> > >> Signed-off-by: Emil Velikov <[email protected]> > > > > I definitely agree that updating the README, especially regarding > > versioning, is valuable. But, I'm not sure that the changes in this > > specific patch communicates anything different than what already exists. > > > You are correct - the core of the information is essentially the same, > just emphasis was changed. Sort of like "I brought the box" vs "The > box was brought by me". > > > Regardless, some notes inline, below. > > > > > >> --- > >> README | 22 +++++++++++----------- > >> 1 file changed, 11 insertions(+), 11 deletions(-) > >> > >> diff --git a/README b/README > >> index 110a14b..76be7b9 100644 > >> --- a/README > >> +++ b/README > >> @@ -73,17 +73,17 @@ http://ometer.com/parallel.html > >> Libweston design goals > >> ---------------------- > >> > >> -The high-level goal of libweston is that what used to be shell plugins > >> -will be main executables. Instead of launching 'weston' with various > >> -arguments to choose the shell, one would be launching > >> -'weston-desktop', 'weston-ivi', 'orbital', etc. The main executable > >> -(the hosting program) links to libweston for a fundamental compositor > >> -implementation. Libweston is also intended for use by other projects > >> -who want to create new "Wayland WMs". > >> - > >> -The libweston API/ABI will be separating the shell logic and main > >> -program from the rest of the "Weston compositor" (libweston > >> -internals). > >> +The high-level goal of libweston is to decouple the compositor from > >> +the the shell logic (what used to be shell plugins). > > > > perhaps "shell implementation" instead of "shell logic." > > > > > >> + > >> +Thus the instead of having a single 'weston' launched with various > > > > Thus, instead of launching 'weston' with... > > > >> +arguments to choose the shell, one would be launching 'weston-desktop', > > > > one would launch the shell itself, eg. 'weston-desktop', ... > > > >> +'weston-ivi', 'orbital', etc. The main executable (the hosting program) > >> +will implement the shell, while libweston will be used for a fundamental > >> +compositor implementation. > >> + > >> +Libweston is also intended for use by other projects who want to create > > > > by other projects that want > > or > > by other project developers who want > > > You do realise that all those hunks were exactly as-is even before my > change, right ;-) Personally I don't might either way, but I'll give > it a couple of days for others to voice their input before > re-spinning. Yong's suggestions are fine by me, feel free to integrate if you want. Thanks, pq
pgp4dXywvrzHo.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
