On Mon, 4 Apr 2016 17:55:29 -0500 Yong Bakos <[email protected]> wrote:
> > Date: Sun, 3 Apr 2016 01:47:43 +0100 > > From: Eric Engestrom <[email protected]> > > To: [email protected] > > Cc: Eric Engestrom <[email protected]> > > Subject: [PATCH libinput] fix spelling mistakes > > Message-ID: <[email protected]> > > > > Signed-off-by: Eric Engestrom <[email protected]> > > --- > > doc/t440-support.dox | 2 +- > > src/evdev-tablet.c | 2 +- > > src/evdev.c | 2 +- > > src/filter.c | 2 +- > > src/libinput.h | 8 ++++---- > > 5 files changed, 8 insertions(+), 8 deletions(-) > > > > Looks good, thanks. (Note that I am a novice reviewer.) Hi Yong, thank you for participating! When you review things, you should include a line like this: Reviewed-by: Real Name <[email protected]> People pushing patches upstream will collect that and make it part of the commit message, like this: https://cgit.freedesktop.org/wayland/weston/commit/?id=273874e3c715a7102add0030f200d0a0f17628fa We also use Acked-by when a particular person accepts the change in principle, but has not properly reviewed the changes. This is usually when that person's acceptance is important somehow. Btw. your recent review emails do not appear as replies to the patch emails. This makes matching them to the particular (revision of) the patch quite hard. Thanks, pq
pgpNNKGC2GDpu.pgp
Description: OpenPGP digital signature
_______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
