Hi Pekka-san, Basically, it looks good. But I have one question:
Would it not be better to merge ivi-shell.c and ivi-layout.c together, if they are the some component ? We can then merge also ivi_layout struct to ivi_shell struct, and ivi_layout_surface struct to ivi_shell_surface struct etc. I do not see any disadvantage not to do so. Best regards Emre Ucan Software Group I (ADITG/SW1) Tel. +49 5121 49 6937 > -----Original Message----- > From: Pekka Paalanen [mailto:[email protected]] > Sent: Dienstag, 15. März 2016 16:40 > To: [email protected] > Cc: Ucan, Emre (ADITG/SW1); wataru_natsume; Pekka Paalanen > Subject: [PATCH weston 0/5] ivi-shell untangling > > From: Pekka Paalanen <[email protected]> > > Hi, > > here are few clean-ups for ivi-shell, and removal of a signal in favour of a > direct unconditional call. I'm also extracting the ivi-shell facing API part > out of > ivi-layout-private.h to make it a little more readable. > > > Thanks, > pq > > Pekka Paalanen (5): > ivi-shell: include config.h in ivi-layout-transition.c > ivi-shell: add include guards on ivi-shell.h > ivi-shell: call send_surface_send_configure() directly > ivi-shell: remove configured signal from ivi-layout > ivi-shell: introduce ivi-layout-shell.h > > Makefile.am | 1 + > ivi-shell/ivi-layout-private.h | 24 +------------- > ivi-shell/ivi-layout-shell.h | 67 > +++++++++++++++++++++++++++++++++++++++ > ivi-shell/ivi-layout-transition.c | 7 +++- > ivi-shell/ivi-layout.c | 38 +++++++--------------- > ivi-shell/ivi-shell.c | 42 ++++++++++-------------- > ivi-shell/ivi-shell.h | 9 ++++++ > 7 files changed, 113 insertions(+), 75 deletions(-) create mode 100644 ivi- > shell/ivi-layout-shell.h > > -- > 2.4.10 _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
