Hello Bryce, I will check this out and send a new patch set.
Thank you. Best regards Emre Ucan Software Group I (ADITG/SW1) Tel. +49 5121 49 6937 -----Original Message----- From: Bryce Harrington [mailto:[email protected]] Sent: Mittwoch, 2. März 2016 20:42 To: Ucan, Emre (ADITG/SW1) Cc: [email protected] Subject: Re: [PATCH weston 00/14] IVI Layout API Cleanup On Mon, Feb 29, 2016 at 08:04:05AM +0000, Ucan, Emre (ADITG/SW1) wrote: > Hello Bryce, > > As far as I know, there are two controller plugins which are using ivi layout > interface. > 1. HMI controller > 2. IVI controller in Genivi Wayland IVI Extension > > I updated the hmi controller for these changes, and ivi controller does not > use these APIs. > > Furthermore, IVI Layout APIs are internal. It is quite often that weston > plugins gets break after a major release because of either API changes or > data struct changes. > > For example, we have an input plugin in Wayland IVI Extension which replaces > the default grab interfaces. The plugin does not compile with 1.10 weston > because weston_pointer data struct is changed after 1.9. > Hi Ucan, On my system I'm seeing the ivi-layout-internal-test.la test case failing starting with patch 4, and ivi-layout-test.la breaking starting with patch 5. [11:35:45.338] Assert failure in tests/ivi_layout-test-plugin.c:472, runner_func_surface_position: 'prop->dest_x == 20' [11:35:45.338] Assert failure in tests/ivi_layout-test-plugin.c:473, runner_func_surface_position: 'prop->dest_y == 30' and [11:35:45.310] Assert failure in tests/ivi_layout-internal-test.c:455, test_layer_bad_opacity: 'prop->opacity == wl_fixed_from_double(0.0)' The first appears to be just a stray surface_get_position() call that was missed. I'm not sure what's going on in the second; something to do with opacity ending up with an unexpected value? Thanks, Bryce make check-am make[1]: Entering directory `/home/bryce/src/Wayland/weston' make check-TESTS make[2]: Entering directory `/home/bryce/src/Wayland/weston' make[3]: Entering directory `/home/bryce/src/Wayland/weston' PASS: internal-screenshot.weston PASS: config-parser.test PASS: vertex-clip.test PASS: zuctest PASS: surface-test.la PASS: surface-global-test.la FAIL: ivi-layout-internal-test.la FAIL: ivi-layout-test.la PASS: bad_buffer.weston PASS: keyboard.weston PASS: event.weston PASS: button.weston PASS: text.weston PASS: presentation.weston PASS: roles.weston PASS: subsurface.weston PASS: devices.weston SKIP: buffer-count.weston PASS: xwayland-test.weston PASS: ivi-shell-app.weston make[4]: Entering directory `/home/bryce/src/Wayland/weston' make all-am make[5]: Entering directory `/home/bryce/src/Wayland/weston' make[5]: Leaving directory `/home/bryce/src/Wayland/weston' make[4]: Leaving directory `/home/bryce/src/Wayland/weston' ============================================================================ Testsuite summary for weston 1.10.90 ============================================================================ # TOTAL: 20 # PASS: 17 # SKIP: 1 # XFAIL: 0 # FAIL: 2 # XPASS: 0 # ERROR: 0 ============================================================================ See ./test-suite.log Please report to https://bugs.freedesktop.org/enter_bug.cgi?product=Wayland&component=weston&version=1.10.90 ============================================================================ make[3]: Leaving directory `/home/bryce/src/Wayland/weston' make[2]: Leaving directory `/home/bryce/src/Wayland/weston' make[1]: Leaving directory `/home/bryce/src/Wayland/weston' _______________________________________________ wayland-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/wayland-devel
