Hi, On 13 January 2016 at 02:14, Jonas Ådahl <[email protected]> wrote: > This patch introduces a new protocol for locking and confining a > pointer. It consists of a new global object with two requests; one for > locking the surface to a position, one for confining the pointer to a > given region. > > Signed-off-by: Jonas Ådahl <[email protected]> > Reviewed-by: Peter Hutterer <[email protected]> > Reviewed-by: Derek Foreman <[email protected]>
Hm, seems like we're dangerously close to agreement after however long it's taken ... > Changes since v2: > > Added a "lifetime" enum which is passed to the locking/confining requests. It > is used to specify whether the constraints should be oneshot or reoccurring. > Oneshot and reoccurring both has race conditions when they are deactivated, > and > this enables the client to choose what race condition it prefers. ... so best bikeshed something. Please change 'reoccurring' to either recurring, or perhaps 'persistent' as even better. > + <arg name="lifetime" type="uint" summary="lock lifetime"/> Missing enum tag? The rest looks good to me, so given these are minor enough that they can be fixed when pushing: Reviewed-by: Daniel Stone <[email protected]> Cheers, Daniel _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
