On Wed, Oct 21, 2015 at 07:58:17PM -0700, Bryce Harrington wrote: > On Thu, Oct 22, 2015 at 11:44:49AM +0900, Tomohito Esaki wrote: > > From: Shinya Saito <[email protected]> > > > > When trying to do sceen recording using the screenshooter, no screen data > > was ever processed because the rpi-renderer never set the previous frames > > damage area. > > > > Update the rpi-renderer to copy the necessary data. > > > > Signed-off-by: Shinya Saito <[email protected]> > > Signed-off-by: Tomohito Esaki <[email protected]> > > --- > > > > Tested on weston v1.8.0 > > Compile tested on v1.9.0. (I don't have access to a Raspberry Pi right now) > > I see looking at both pixman_renderer_repaint_output() and > gl_renderer_repaint_output() that they both make this call, so this fix > looks appropriate, but can't test it either so dunno if it's sufficient. > > Reviewed-by: Bryce Harrington <[email protected]> > > Anyone have a rpi device to check and give a Tested-by on this?
Guess not, but no reason to further hold this patch back, so pushed: remote: I: patch #62570 updated using rev 2071f1fbbf6436724e9cb325ba3bca44edd0022a remote: I: 1 patch(es) updated to state Accepted. To ssh://git.freedesktop.org/git/wayland/weston 0c0e51e..2071f1f master -> master > > src/rpi-renderer.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/rpi-renderer.c b/src/rpi-renderer.c > > index d0a9797..76e1ddf 100644 > > --- a/src/rpi-renderer.c > > +++ b/src/rpi-renderer.c > > @@ -1410,6 +1410,7 @@ rpi_renderer_repaint_output(struct weston_output > > *base, > > /* The frame_signal is emitted in rpi_renderer_finish_frame(), > > * so that the firmware can capture the up-to-date contents. > > */ > > + pixman_region32_copy(&base->previous_damage, output_damage); > > } > > > > static void > > -- > > 1.8.0 > > > > _______________________________________________ > > wayland-devel mailing list > > [email protected] > > http://lists.freedesktop.org/mailman/listinfo/wayland-devel > _______________________________________________ > wayland-devel mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/wayland-devel _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
