On Thu, Oct 1, 2015 at 12:23 PM Pekka Paalanen <[email protected]> wrote: > > On Thu, 01 Oct 2015 17:13:47 +0900 > Nobuhiko Tanibata <[email protected]> wrote: > > > Hi, > > > > Tested-by: Nobuhiko Tanibata <[email protected]> > > Reviewed-by: Nobuhiko Tanibata <[email protected]> > > > > These constructors are reserved for a feature of 'a ivi-surface to > > several layers' and 'a ivi-layer to several screens'. This feature is > > required for > > - for example, car navigation application prepares junction guide on a > > surface, which shall be displayed in its own UI and cloned on > > instrumental cluster in another screen as well. In this case, a > > ivi-surface can be located in both.
I realize this is a hypothetical feature and certainly not for now, but.... I understand the need for showing the same thing in more than one screen. But is it sure that using the same shell surface and allowing it to be in more than one layer is the correct approach? The current code has properties such as destination region and visiblity that are part of the surface. These semantics are exported in ivi-layout-export.h. I would be tempted to look into using the same wl_buffer attached to two wl_surfaces, but it's too much for me when I start thinking about how the releasing of the buffer would work. Maybe other shells have done this, or would be interested in it? This question would also arise if using one ivi_surface on two ivi_layers. Regards, Frederico > > > > However, I have to modify weston core to realize it. So, for the time > > being, we can remove them at this time to simplify codes. > > Hi, > > I'm not sure you need to modify Weston core. You need to create > one weston_view for each ivi-screen/ivi-layer/ivi-surface combination. > > Emre, these are nice clean-ups. I have a couple of comments for the > future: > - mind the line length in the commit message, I re-wrapped all the > patches > - use a space after a keyword like 'if', I think there were a few without > > Pushed all 5 patches: > dcba1a1..64635ee master -> master > > > Thanks, > pq > _______________________________________________ > wayland-devel mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/wayland-devel _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
