On Mon, Aug 17, 2015 at 11:29:01AM +0300, Pekka Paalanen wrote: > On Thu, 13 Aug 2015 12:30:00 +0200 > Giulio Camuffo <[email protected]> wrote: > > > The first patch by Pekka adds some functions to ease a smooth migration > > from the old way of initializing the backends to a new one which is > > libweston friendly. > > The other two patches make the drm and wayland backends use that new way. > > The other backends will follow if we're ok with the direction this is going. > > > > Giulio Camuffo (2): > > drm: port the drm backend to the new init api > > wayland: port the wayland backend to the new api > > > > Pekka Paalanen (1): > > compositor: prep for migration to new config system > > > > Makefile.am | 6 + > > src/compositor-drm.c | 233 +++++++++------------------ > > src/compositor-drm.h | 89 +++++++++++ > > src/compositor-fbdev.c | 3 +- > > src/compositor-headless.c | 3 +- > > src/compositor-rdp.c | 3 +- > > src/compositor-rpi.c | 3 +- > > src/compositor-wayland.c | 219 +++++--------------------- > > src/compositor-wayland.h | 58 +++++++ > > src/compositor-x11.c | 3 +- > > src/compositor.h | 21 ++- > > src/main.c | 392 > > ++++++++++++++++++++++++++++++++++++++++++++-- > > 12 files changed, 675 insertions(+), 358 deletions(-) > > create mode 100644 src/compositor-drm.h > > create mode 100644 src/compositor-wayland.h > > > > Hi all, > > what do people think of landing this stuff before the 1.9-beta release, > would anyone object? IMO it's ok as it's only Weston internals > restructuring.
Conceptually I like the patches, but the changes seem a little jumbled. I'll try and provide more constructive feedback separately. While these mostly just are refactoring internals, the size of the patches worries me a bit simply that the quantity of code changes might hide a bug or two. Correct me if I'm wrong, but more work is still needed before libweston is a usable library for end users, and whether this lands or waits a bit won't impact that? Assuming that's true, I'd kind of prefer holding off on landing these until 1.10, and get a bit more review and testing done on them. Maybe there's some smaller bits that would be ok to land; I'll try to flag what looks safe to me. Bryce > Of course I need to review the patches first, and I'd like at least an > ack for the first patch from someone else. > > "This stuff" would be the backend conversion patches like done for DRM > and Wayland backends in this series and possibly some more libweston > preparatory work, but not the patch to build libweston.so as we already > agreed the cut-off point for that was the alpha release. > > Hmm, need to patch README to not say "Libweston was first introduced in > Weston 1.9"... > > Oh yeah, I'm also aware of > https://bugs.freedesktop.org/show_bug.cgi?id=91654 > > > Thanks, > pq > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2 > > iQIVAwUBVdGbVCNf5bQRqqqnAQiRcA//eRBftcguI7pqRqaCpYRnLzzf5jprt3fk > cyXlD/fEVb7oGxzMCRkmGn32+2bxXH3ujJpeXVIBAc0kPkkVycAqH0uxzaH+7Syk > RS2o82RSkVrf8qQHcPkPWMV2d1C35fqr2bF9pSJJAPZlfGxpFKJ4IObAv9632Zfp > pJrssTYjeftPy+gVX2a4sXWVh528pO2qp8ioOAJ5MFtr6LfWov1WTEcD8VKtiBUC > udEU7XctEDUCtOIBSILQeLRwOCjG5u67n9w3SHwFhU3pKWrlIfmFYNNX+ETN5Ue5 > NohFy9Asfsptjkb6hrjrrU3MF9ypq3WU86yyPwZKgX/dYQzSMQmi4f15HSpTIyvg > gdmXFSx5ws2152qt15L95o6mLXSUMpyplfFNnTkHDdNKaKNataDMLNy3WKNKymrJ > VOLxnI7CqGsIznUs7+1YFmNeE4u63VFQ8JVrKpeTUQK4WIYIXDh/AJq+c26zQDv/ > 1+mZ+IPgFiyuXCuNOM2z0CyumVeY2ln/7Vg1QXm8qtCTu1h+S2LSSVajO/zSmDZo > neP0FgKnpQVTCDaiQYe/hn6l+847rXizHNpohtGNK9Ny1R1rEsX2LIHjZ5CJNFBy > cx+WpJ4fm/yF1n85BShkDdaZDNm1leeQ/efNDIWZ/nXy5czBi48CuXuqDP9kPIih > oW45eklDHlk= > =RR3y > -----END PGP SIGNATURE----- _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
