On 21/06/15 02:25 PM, Mario Kleiner wrote:
> Allows to force loading an identity gamma table if
> option icc_profile=identity is given in weston.ini for
> an output.
> 
> Some special display output devices, e.g., for
> neuro-science applications, and special display
> testing hardware need a guaranteed perfect pixel
> passthrough from framebuffer to output. This is
> an easy way to set this up for cms-static.
> 
> v2: Remove confusing/redundant weston_log debug output.
> 
> Signed-off-by: Mario Kleiner <[email protected]>
> ---
>  src/cms-static.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/cms-static.c b/src/cms-static.c
> index 7166f57..e6073df 100644
> --- a/src/cms-static.c
> +++ b/src/cms-static.c
> @@ -56,7 +56,7 @@ cms_output_created(struct cms_static *cms, struct 
> weston_output *o)
>       if (weston_config_section_get_string(s, "icc_profile", &profile, NULL) 
> < 0)
>               return;
>       p = weston_cms_load_profile(profile);
> -     if (p == NULL) {
> +     if (p == NULL && strcmp(profile, "identity")) {
>               weston_log("cms-static: failed to load %s\n", profile);
>       } else {
>               weston_log("cms-static: loading %s for %s\n",
>

Can we use the empty string instead of "identity"?  Or is it intentional
that someone could override "identity" with a file of that name?

Should we just load an identity gamma curve if there's no profile
specified anyway?  Or is there a situation where someone wants to mess
up the gamma curve before launching weston?
_______________________________________________
wayland-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Reply via email to