On Fri, 12 Jun 2015 11:19:01 +0300 Pekka Paalanen <[email protected]> wrote:
> On Thu, 11 Jun 2015 12:14:45 -0500 > Derek Foreman <[email protected]> wrote: > > > EGLGetDisplay() doesn't generate a GL error, so we shouldn't print one. > > That's generally true, with one little exception: > > https://www.khronos.org/registry/egl/extensions/EXT/EGL_EXT_platform_base.txt > > "An EGL_BAD_PARAMETER error is generated if <platform> has an invalid value. > If <platform> is valid but no display matching <native_display> is > available, then EGL_NO_DISPLAY is returned; no error condition is raised > in this case." > > Checking that would be quite inconvenient I think, so this patch is fine. > > > I've also renamed the goto labels so it's a little clearer when to use them. > > > > Signed-off-by: Derek Foreman <[email protected]> > > --- > > src/gl-renderer.c | 12 ++++++------ > > 1 file changed, 6 insertions(+), 6 deletions(-) > > Reviewed-by: Pekka Paalanen <[email protected]> Pushed: 867d50e..066ca0c master -> master Thanks, pq _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
