On Fri, 1 May 2015 11:46:36 -0500 Derek Foreman <[email protected]> wrote:
> Really, there's pretty much no time we'd ever want O_CLOEXEC unset, > as it will likely result in leaking fds to processes that aren't > interested in them or shouldn't have them. > > This also removes the (now unused) code from weston_logind_open() that > could drop O_CLOEXEC. > > Signed-off-by: Derek Foreman <[email protected]> > --- > Daniel suggested I do something like this instead of fixing all the > callers as I did in my previous patches. > > I think this should supersede my previous two patches on the subject. > > It's still possible for someone to leak fds to child processes if they > really want to (by using fcntl to clear O_CLOEXEC). I really can't think > of a use case for that. By making it much harder to do on purpose it's > become almost impossible to do by accident... > > src/launcher-util.c | 8 +++++++- > src/logind-util.c | 20 ++------------------ > 2 files changed, 9 insertions(+), 19 deletions(-) Pushed. b0f5a25..2663c68 master -> master Thanks, pq _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
