Hi Bryce, On 15 May 2015 at 09:21, Bryce Harrington <[email protected]> wrote: > This series adds support for implementing test cases that can check > rendering output without needing connection to a physical output. It > utilizes the pixman renderer in the headless backend to generate > screenshots at the request of the test client. > > The test creates a shm buffer and passes it to the server via the > Weston-Test protocol ('capture_screenshot'). The server then renders > the display contents into the buffer and returns it as a response > ('capture_screenshot_done'). > > The test then loads a corresponding reference PNG from disk using Cairo, > and then compares it with the captured screenshot. Note that the > screenshot includes the current time in the desktop clock, which will of > course be different in the captured screenshot from the reference image. > So this checks a small clipped out section of each of the two images to > verify congruence. > > By default, Wayland fades in the display and will show a patterned > background. The former feature causes a black or nearly-black image to > be captured (the darkness of which may vary from system to system), and > the latter merely adds noise in our comparison, so both features are > disabled via a test-specific configuration .ini file.
Thanks for these. There are still some stride issues on patch 4, but for all the rest: Reviewed-by: Daniel Stone <[email protected]> If you want a quicker pass over a revised 4, feel free to ping me patches on IRC and I can give R-b there. These look good to land in general; they're not perfect, but I'd much rather have them in there and just fix them up later. Cheers, Daniel _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
