On 13 February 2015 at 15:24, Daniel Stone <[email protected]> wrote: > Hi, > > On 10 February 2015 at 14:42, Emil Velikov <[email protected]> wrote: >> -AC_PATH_PROG([wayland_scanner], [wayland-scanner]) >> +PKG_CHECK_MODULES(WAYLAND_SCANNER, [wayland-scanner], >> + wayland-scanner=`$PKG_CONFIG --variable=wayland-scanner >> wayland-scanner, > > Missing ` (backtick) at the end. > > The nice thing the AC_PATH_PROG check gives us is the ability to > override it on the ./configure command line, which should be preserved > above all autodetection, so I guess your patch should be reworked to > handle that. > Hmm I've just double checked, but overwriting the variable (wayland_scanner) at configure time does not work with or without this patch. Did you had in mind replacing it at make time - $ make wayland_scanner="echo FOO".
I have confirmed that the latter works like a charm before/after this change (barring the silly mistakes of course). Cheers, Emil _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
