Hi,
On 05-02-15 06:13, Bobby Powers wrote:
On the 3rd gen x1 carbons, if your finger is at the very bottom of the
touchpad, you can click the touchpad without it registering your
finger as a touch down. Treat this case the same as a single-finger
left click, which matches my intention.
Signed-off-by: Bobby Powers <[email protected]>
Thanks for the patch, I agree that this is a good idea (for clickfinger
configs).
I do have 2 requests:
---
src/evdev-mt-touchpad-buttons.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/evdev-mt-touchpad-buttons.c b/src/evdev-mt-touchpad-buttons.c
index ca7495f..aacfc92 100644
--- a/src/evdev-mt-touchpad-buttons.c
+++ b/src/evdev-mt-touchpad-buttons.c
@@ -786,7 +786,7 @@ tp_notify_clickpadbutton(struct tp_dispatch *tp,
case 2: button = BTN_RIGHT; break;
case 3: button = BTN_MIDDLE; break;
default:
- button = 0;
+ button = BTN_LEFT;
}
tp->buttons.active = button;
@@ -840,7 +840,7 @@ tp_post_clickpadbutton_buttons(struct tp_dispatch *tp,
uint64_t time)
}
}
- if (button == 0) {
+ if (button == 0 && tp->buttons.click_method !=
LIBINPUT_CONFIG_CLICK_METHOD_CLICKFINGER) {
1) This line is longer then 80 chars, please break it.
/* No touches, wait for a touch before processing */
tp->buttons.click_pending = true;
return 0;
2) After applying this patch "make check" fails, can you please fixup the
test-suite
to not fail with this patch ?
Regards,
Hans
_______________________________________________
wayland-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/wayland-devel
