On 01/12/2015 09:14 AM, Giulio Camuffo wrote:

+static bool
+weston_wm_window_inactive(struct weston_wm_window *window)
+{
+       struct weston_wm *wm = window->wm;
+
+       return window->type == wm->atom.net_wm_window_type_tooltip ||
+              window->type == wm->atom.net_wm_window_type_dropdown ||
+              window->type == wm->atom.net_wm_window_type_dnd ||
+              window->type == wm->atom.net_wm_window_type_combo ||
+              window->type == wm->atom.net_wm_window_type_popup;
+}

I think maybe this should be called "window_type_inactive" because the current name implies this is some kind of check for whether the window is "currently inactive". Also is it necessary to namespace the static function with "weston_wm_" prefix?
_______________________________________________
wayland-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Reply via email to