On Tue, Nov 04, 2014 at 01:14:20PM +0200, Pekka Paalanen wrote: > Hi all, > > some of you already know that we now have > http://patchwork.freedesktop.org/project/wayland/list/ > to keep track of the patches sent to wayland-devel mailing list. > > Thanks to Daniel for setting that up. :-)
Ditto thanks Daniel, and thanks pq for this guidance in using it! > You change the patch status by clicking the patch link in the list, and > on the following page you should have box titled "Patch Properties" > near the top. If you don't see that, you don't have permissions to > change it (e.g. not logged in, or unregistered email address). There are several defined states: New Under Review Accepted Rejected RFC Not Applicable Changes Requested Awaiting Upstream Superseded Deferred Some of these seem obvious, others less so. I think it would help to have a glossary of what they mean, so we use them consistently. I poked around but didn't see one. In particular, if I review someone else's patch and feel it is fine to be landed, how do I mark it to signal to the Committers "this is ready to land"? Should I mark it Accepted? Do I Delegate it to one of the Committers? When is Under Review used? Looking at the patchwork source this state and New are the two 'action_required' states, so perhaps Under Review should be for incoming patches that need someone to review them? > Shortcomings: > > There are several features we would like to see in Patchwork but AFAIK > are not there (yet?). Patchwork does not recognize re-submissions so > that it could automatically set a patch as "Superseded". Might be nice if it permitted project-specific states, or even just a richer set of states to track things like if the patch has passed the testsuite, and to differentiate between okay-in-concept reviews and code quality reviews. > It does not maintain patch sets. You can create "Bundles", but so far > those are just named collections of individual patches, and you need > to create them manually. If I create a Bundle of patches (e.g. Derek's large transform patchset), does that help others? Or are Bundles just personal? Bryce _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
