On Mon, 13 Oct 2014 11:41:32 -0700 Bryce Harrington <[email protected]> wrote:
> On Fri, Oct 03, 2014 at 01:13:42PM -0500, Derek Foreman wrote: > > For functions that test if something is true/valid and return a 1 > > or 0, it makes sense to switch to bool. > > I like it. Probably many other places this shows up. > > Only question I have is if bool can be used for WL_EXPORT functions? > bool isn't mentioned in the wire format docs[0], so I'm guessing that > might not be an allowed type for those routines? This is a Weston patch and I don't see anything suspicious in using stdbool.h, so it's ok here. I kind of wonder what including stdbool.h does to C++ sources using compositor.h, but if that breaks, we'll hear about it. Looks good to me, so pushed! Thanks, pq > > Assuming that's fine, > > Reviewed-by: Bryce Harrington <[email protected]> > > 0: http://wayland.freedesktop.org/docs/html/sect-Protocol-Wire-Format.html > > > --- > > src/cms-colord.c | 10 +++++----- > > src/compositor.c | 20 ++++++++++---------- > > src/compositor.h | 5 +++-- > > src/input.c | 8 ++++---- > > src/weston-launch.c | 11 ++++++----- > > 5 files changed, 28 insertions(+), 26 deletions(-) _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
