Title: Samsung Enterprise Portal mySingle

Hi

Thank You Pekka for review comments. I will bump the revision on wl_data_device_manager and submit another patch.

With Thanks and Regards

Kabeer

------- Original Message -------

Sender : Pekka Paalanen<[email protected]>

Date : Aug 26, 2014 20:46 (GMT+09:00)

Title : Re: [PATCH v2 1/2] Protocol: Add destructor to wl_data_device interface Fix for Bug# 81745

 

On Fri, 22 Aug 2014 19:16:49 +0530
[email protected] wrote:

> From: kabeer
>
> Signed-off-by: kabeer
> ---
>  protocol/wayland.xml |    9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
> index bb457bc..1d3b24f 100644
> --- a/protocol/wayland.xml
> +++ b/protocol/wayland.xml
> @@ -517,7 +517,7 @@
>  
>    
>  
> -  
> +  
>      
>        There is one wl_data_device per seat which can be obtained
>        from the global wl_data_device_manager singleton.
> @@ -640,6 +640,13 @@
>        

>        
>      
> +    
> +    
> +    
> +    
> +      
> +   

> +    

>    

>  
>    

Hi,

this is better, just one more thing. When you bump revision here, you
also need to bump the revision on wl_data_device_manager, because that
is the interface that creates wl_data_device objects. This applies
recursively, but wl_data_device_manager is a global, so there is no
interface above it to bump.

Since we are in the alpha phase, I will need another review on the
final series, too. Otherwise this will need to wait until 1.7
development cycle begins.


Thanks,
pq

 

 

_______________________________________________
wayland-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Reply via email to