Kristian, Other than the "return FALSE" mentioned below, this looks good-to-go. --Jason Ekstrand
On Wed, Apr 2, 2014 at 7:43 PM, Jason Ekstrand <[email protected]> wrote: > > > > On Wed, Apr 2, 2014 at 7:08 PM, Bill Spitzak <[email protected]> wrote: > >> Hardening wrote: >> >> + if (!settings->DesktopResize) { >>> + /* peer does not support desktop resize >>> */ >>> + weston_log("%s: client doesn't support >>> resizing, closing connection\n", __FUNCTION__); >>> + client->Close(client); >>> >> >> + target_mode = ensure_matching_mode(&output->base, >>> &new_mode); >>> >>> + if (!target_mode) { >>> + weston_log("client mode not found\n"); >>> + return FALSE; >>> + } >>> >> >> One failure mode is fatal, while the other one just returns FALSE? Both >> just mean that weston's size is different than the RDP window size, so I >> think the results should be the same. >> > > Actually, I *think* what he's doing here is sane. However, we should > probably return FALSE in both cases. > --Jason Ekstrand >
_______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
