On Wed, Mar 26, 2014 at 04:21:47AM +0100, [email protected] wrote: > On 25/03/2014 21:45, Jonas Ådahl wrote: > >Signed-off-by: Jonas Ådahl <[email protected]> > >--- > > test/Makefile.am | 15 ++++++++------- > > 1 file changed, 8 insertions(+), 7 deletions(-) > > > >diff --git a/test/Makefile.am b/test/Makefile.am > >index b59d4a9..12ed023 100644 > >--- a/test/Makefile.am > >+++ b/test/Makefile.am > >@@ -2,6 +2,7 @@ if BUILD_TESTS > > AM_CPPFLAGS = -I$(top_srcdir)/src $(CHECK_CFLAGS) $(LIBEVDEV_CFLAGS) > > > > TEST_LIBS = liblitest.la $(CHECK_LIBS) $(LIBUDEV_LIBS) $(LIBEVDEV_LIBS) > > $(top_builddir)/src/libinput.la -lm > >+TEST_CFLAGS = $(GCC_CFLAGS) $(AM_CPPFLAGS) > > AM_CPPFLAGS is wrong here, it must be AM_CFLAGS. The way it is > currently written (or with this patch) AM_CPPFLAGS are passed twice > while AM_CFLAGS are ignored. It may not be important but it is still > wrong. > You could also drop TEST_CFLAGS altogether and append the GCC_CFLAGS > to AM_CFLAGS in configure.ac. > > (In your C++ test patch, you should also add AM_CXXFLAGS to > test_build_cxx_CXXFLAGS.) >
Thanks for the review, Quentin. I addressed the issues locally and pushed them as http://cgit.freedesktop.org/wayland/libinput/commit/?id=79827d24227c7ccbc8c238fb12f8eac12182ca1c and http://cgit.freedesktop.org/wayland/libinput/commit/?id=07750ef7988a98c1b3216fb6d52937c9ca07b539 Jonas > > -- > > Quentin “Sardem FF7” Glidic _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
