On Wed, Nov 20, 2013 at 04:25:39PM +0100, Marek Ch wrote:
> Fix 'unused variable' and 'missing initializer' warnings and
> remove trailing whitespaces in connection-test
> @@ -517,6 +523,7 @@ suu_handler(void *data, struct wl_object *object,
> {
> int *done = data;
>
> + assert(object && data && s);
It might be helpful to test each of the parameters separately in this
and the other asserts this patch adds. If the assert ever does happen
to hit, then that way the tester would know precisely which arg was at
fault.
assert(object);
assert(data);
assert(s);
Other than that, the rest of the patch series LGTM.
Reviewed-by: Bryce Harrington <[email protected]>
> assert(strcmp(s, "foo") == 0);
> assert(u1 = 500);
> assert(u2 = 404040);
> --
> 1.8.4.2
>
> _______________________________________________
> wayland-devel mailing list
> [email protected]
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
_______________________________________________
wayland-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/wayland-devel
