On Sun, Oct 13, 2013 at 07:08:37PM -0500, Jason Ekstrand wrote: > This splits the decorations code out from window.c so that it can also be > used by the xwayland WM and other weston components. > > Jason Ekstrand (4): > Rename frame_create and frame_set_child_size with a window_ prefix > Add decoration frame support to cairo-util > Use cairo-util frame in tinytoolkit > xwayland: Use decoration frame from cairo-util
This series looks great, you split that out very nicely. There is a missing frame_create rename in editor.c (I've squashed a fix in locally). The failure to close glxgears is because glxgears doesn't support the WM_DELETE_WINDOW protocol, something a conforming window should advertise in the WL_PROTOCOLS window property. I added a few lines to parse the WM_PROTOCOLS property (we alread ready it) and fall back to xcb_kill_client() if the window doesn't support WM_DELETE_WINDOW. I'm almost ready to push this, but I'll just see if I can add back the touch functionality tomorrow when I get to my touch screen so we don't regress that. Kristian > clients/clickdot.c | 2 +- > clients/cliptest.c | 2 +- > clients/desktop-shell.c | 2 +- > clients/dnd.c | 4 +- > clients/eventdemo.c | 2 +- > clients/image.c | 2 +- > clients/nested.c | 2 +- > clients/resizor.c | 2 +- > clients/subsurfaces.c | 2 +- > clients/terminal.c | 4 +- > clients/window.c | 587 ++++++++++-------------------------- > clients/window.h | 5 +- > shared/Makefile.am | 2 + > shared/cairo-util.h | 111 +++++++ > shared/frame.c | 673 > ++++++++++++++++++++++++++++++++++++++++++ > src/xwayland/window-manager.c | 160 ++++++---- > 16 files changed, 1054 insertions(+), 508 deletions(-) > create mode 100644 shared/frame.c > > -- > 1.8.3.1 > > _______________________________________________ > wayland-devel mailing list > [email protected] > http://lists.freedesktop.org/mailman/listinfo/wayland-devel _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
