On Mon, Aug 26, 2013 at 08:40:23PM +0000, Eoff, Ullysses A wrote: > There may be some unintended side-effects by removing it > from compositor.h... that is, other Weston source files might > include compositor.h and assume it brings in config.h. Did > you check for these consequences?
I did, we include config.h from all .c files in src/, so removing the include in compositor.h is safe. Patch applied on master and 1.2, thanks Pier. Kristian > > ---- > U. Artie Eoff > > > -----Original Message----- > > From: wayland-devel-bounces+ullysses.a.eoff=intel....@lists.freedesktop.org > > [mailto:wayland-devel- > > bounces+ullysses.a.eoff=intel....@lists.freedesktop.org] On Behalf Of Pier > > Luigi Fiorini > > Sent: Friday, August 23, 2013 2:43 PM > > To: wayland-devel@lists.freedesktop.org > > Cc: Pier Luigi Fiorini > > Subject: [PATCH weston 1.2] compositor.h: Don't include config.h > > > > Public headers should not include config.h. > > --- > > src/compositor.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/src/compositor.h b/src/compositor.h > > index 3eaac42..3437aea 100644 > > --- a/src/compositor.h > > +++ b/src/compositor.h > > @@ -28,8 +28,6 @@ > > extern "C" { > > #endif > > > > -#include "config.h" > > - > > #include <pixman.h> > > #include <xkbcommon/xkbcommon.h> > > #include <wayland-server.h> > > -- > > 1.8.3.4 > > > > _______________________________________________ > > wayland-devel mailing list > > wayland-devel@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/wayland-devel > _______________________________________________ > wayland-devel mailing list > wayland-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/wayland-devel _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel
