On 10/18/2012 12:35 PM, Chad Versace wrote: > On 10/18/2012 10:23 AM, Pekka Paalanen wrote: >> On Thu, 18 Oct 2012 09:15:08 -0700 >> Chad Versace <[email protected]> wrote: >> >>> wayland-util.h defined an unprefixed macro, ARRAY_LENGTH, which polluted >>> the global namespace. This caused symbol collisions in projects that >>> defined ARRAY_LENGTH slightly differently. >>> >>> Signed-off-by: Chad Versace <[email protected]> >> >> Hi Chad, >> >> do you have the weston patches to go with these? >> I think Weston code heavily uses both the macros you replaced. > > No, I wasn't aware that the macros were used outside Wayland. The > Weston patches coming soon.
Hmm... I think the ARRAY_LENGTH needs to be revised. Since wayland-util.h:ARRAY_LENGTH is used outside of Wayland, I think it should be renamed to WL_ARRAY_LENGTH rather than __WL_ARRAY_LENGTH because double-underscore symbols are typically private. Opinions? _______________________________________________ wayland-devel mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/wayland-devel
