On Mon, Oct 31, 2011 at 9:05 AM, Zhao, Juan J <juan.j.z...@intel.com> wrote: > Thanks. Sorry for the instant sending patch. :) > Yes, I will change it. Looks like bnf's patch will resolve this. I will check > it tomorrow morning, if that can work well, we do not need this patch.
I just applied Benjamins patch, and it should catch the problem you're trying to handle here. Kristian >> -----Original Message----- >> From: Daniel Stone [mailto:dan...@fooishbar.org] >> Sent: Monday, October 31, 2011 7:14 PM >> To: Zhao, Juan J >> Cc: wayland-devel@lists.freedesktop.org >> Subject: Re: [PATCH 1/2] wl_shell: check the parameter sent by the clients >> >> Hi, >> >> On 31 October 2011 07:17, <juan.j.z...@intel.com> wrote: >> > + if((struct wl_interface *) >> > + (((struct wl_object *)surface_resource)->interface)->name >> > + !="wl_surface") >> >> This is, er, not how you perform string comparison in C. >> >> Cheers, >> Daniel > _______________________________________________ > wayland-devel mailing list > wayland-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/wayland-devel > _______________________________________________ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel