https://bugs.freedesktop.org/show_bug.cgi?id=85879

--- Comment #8 from Jonas Ã…dahl <[email protected]> ---
Comment on attachment 124567
  --> https://bugs.freedesktop.org/attachment.cgi?id=124567
A draft of the interface

Review of attachment 124567:
-----------------------------------------------------------------

::: src/libinput.h
@@ +541,5 @@
> + *
> + * Valid event types for this event are
> + * @ref LIBINPUT_EVENT_TOUCHPAD_TOUCH_DOWN,
> + * @ref LIBINPUT_EVENT_TOUCHPAD_TOUCH_MOTION,
> + * @ref LIBINPUT_EVENT_TOUCHPAD_TOUCH_UP.

Any use for a LIBINPUT_EVENT_TOUCHPAD_FRAME event?

@@ +543,5 @@
> + * @ref LIBINPUT_EVENT_TOUCHPAD_TOUCH_DOWN,
> + * @ref LIBINPUT_EVENT_TOUCHPAD_TOUCH_MOTION,
> + * @ref LIBINPUT_EVENT_TOUCHPAD_TOUCH_UP.
> + */
> +struct libinput_event_touchpad_touch;

Would it maybe be better to just group this as a libinput_event_touchpad event?
I can't think of what other events than touch down/move/up, but grouping it
under "touchpad" would at least not block us/make it awkward to add some other
touchpad specific event.

@@ +4954,5 @@
> + * require changing to a neutral state first before activating the new
> + * method.
> + *
> + * Disabling the direct touch mode on a device that does not have a direct
> + * touch mode always succeeds.

Should it be specified what happens to active gestures (including two finger
scroll, and tap) etc? Do they continue, or are they cancelled in some way?

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
wayland-bugs mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/wayland-bugs

Reply via email to