https://bugzilla.gnome.org/show_bug.cgi?id=756729

Carlos Garnacho <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #313786|none                        |reviewed
             status|                            |

--- Comment #6 from Carlos Garnacho <[email protected]> ---
Review of attachment 313786:

Looks quite alright to me, setting to "reviewed" mostly because this is on hold
till we get protocol bits merged. Only very minor formatting niggles (which I
know the wayland backend code is plagued of, but...).

::: gdk/wayland/gdkdevice-wayland.c
@@ +1080,2 @@
 static void
+flush_scroll_data (GdkWaylandDeviceData *device, GdkWaylandScrollData *scroll)

One argument per line, please :).

@@ +1173,3 @@
+
+static void
+pointer_handle_axis_source(void              *data,

Missing space before '(', variable names should also be aligned to the longest
arg.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
wayland-bugs mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/wayland-bugs

Reply via email to